remove .dynamic from library product #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
approved these changes
Oct 18, 2018
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
Looks good to me. I can’t remember any particular reason why I added the dynamic type.
Member
|
@swift-ci Please test |
rintaro
approved these changes
Oct 19, 2018
Member
|
CC: @nkcsgexi |
nkcsgexi
approved these changes
Oct 19, 2018
Contributor
Author
|
Thanks! |
|
@ahoppen would it be possible to generate a new tag that includes these changes? |
Member
|
CC: @nkcsgexi |
Contributor
|
@loganwright do you mean a new tag for master or for a new release tag (0.40200.0)? |
Contributor
|
+1 to a new release tag that includes this. |
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
Rename to RuleRegistry+Generated.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See SR-9038.
This flag prevents executable SPM projects from embedding
SwiftSyntaxstatically.